Merge pull request 'fix' (#38) from master into dev

Reviewed-on: #38

.deploy/deploy-dev.yaml

@@ -6,13 +6,12 @@ services:
     image: mathwave/sprint-repo:pizda-bot
     command: worker
     environment:
-      MONGO_HOST: "mongo"
+      MONGO_HOST: "mongo.develop.sprinthub.ru"
       MONGO_PASSWORD: $MONGO_PASSWORD_DEV
       STAGE: "development"
     networks:
       - queues-development
       - configurator
-      - mongo-development
     deploy:
       mode: replicated
       restart_policy:
@@ -25,12 +24,11 @@ services:
     image: mathwave/sprint-repo:pizda-bot
     command: api
     environment:
-      MONGO_HOST: "mongo"
+      MONGO_HOST: "mongo.develop.sprinthub.ru"
       MONGO_PASSWORD: $MONGO_PASSWORD_DEV
       STAGE: "development"
     networks:
       - common-infra-nginx-development
-      - mongo-development
     deploy:
       mode: replicated
       restart_policy:
@@ -46,5 +44,3 @@ networks:
     external: true
   configurator:
     external: true
-  mongo-development:
-    external: true

.deploy/deploy-prod.yaml

@@ -6,13 +6,12 @@ services:
     image: mathwave/sprint-repo:pizda-bot
     command: worker
     environment:
-      MONGO_HOST: "mongo"
+      MONGO_HOST: "mongo.sprinthub.ru"
       MONGO_PASSWORD: $MONGO_PASSWORD_PROD
       STAGE: "production"
     networks:
       - queues
       - configurator
-      - mongo
     deploy:
       mode: replicated
       restart_policy:
@@ -25,11 +24,10 @@ services:
     image: mathwave/sprint-repo:pizda-bot
     command: api
     environment:
-      MONGO_HOST: "mongo"
+      MONGO_HOST: "mongo.sprinthub.ru"
       MONGO_PASSWORD: $MONGO_PASSWORD_PROD
     networks:
       - common-infra-nginx
-      - mongo
     deploy:
       mode: replicated
       restart_policy:
@@ -45,5 +43,3 @@ networks:
     external: true
   configurator:
     external: true
-  mongo:
-    external: true

Dockerfile

@@ -4,5 +4,6 @@ WORKDIR /usr/src/app
 COPY requirements.txt requirements.txt
 RUN pip install -r requirements.txt
 COPY . .
+RUN make gen
 ENV PYTHONUNBUFFERED 1
 ENTRYPOINT ["python", "main.py"]

Makefile

@@ -0,0 +1,7 @@
+gen:
+	pip install grpcio grpcio-tools
+	curl https://platform.sprinthub.ru/generator >> generator.py
+	python generator.py
+	rm generator.py
+run:
+	python ./server.py

daemons/base.py

@@ -1,4 +1,6 @@
 import os
+import grpc
+from queues import tasks_pb2_grpc
 
 
 stage = os.getenv("STAGE", 'local')
@@ -9,5 +11,8 @@ else:
 
 
 class Daemon:
+    def __init__(self):
+        self.channel = grpc.insecure_channel(QUEUES_URL)
+        self.stub = tasks_pb2_grpc.TasksStub(channel=self.channel)     
     def execute(self):
         raise NotImplemented

daemons/worker.py

@@ -35,10 +35,6 @@ def get_answers():
     return client.get_config('answers')
 
 
-def get_ignored_users():
-    return client.get_config('ignored_users')['users']
-
-
 def get_replies():
     return client.get_config('replies')
 
@@ -53,6 +49,7 @@ class Daemon(base.Daemon, queues.TasksHandlerMixin):
 
     def reply(self, text: str, chat_id: int, message_id: int):
         queues.set_task(
+            self.stub,
             'botalka_mailbox', 
             {
                 'project': 'pizda-bot',
@@ -68,6 +65,7 @@ class Daemon(base.Daemon, queues.TasksHandlerMixin):
 
     def send(self, text: str, chat_id: int):
         queues.set_task(
+            self.stub,
             'botalka_mailbox', 
             {
                 'project': 'pizda-bot',
@@ -155,6 +153,6 @@ class Daemon(base.Daemon, queues.TasksHandlerMixin):
         else:
             return
         ans = get_answers().get(convert_text)
-        if ans is not None and randrange(1, 101) <= info["probability"] and message.from_user.id not in get_ignored_users():
+        if ans is not None and randrange(1, 101) <= info["probability"]:
             self.reply(ans, message.chat.id, message.message_id)
             mongo.inc(message.from_user.username, message.chat.id)

utils/queues.py

@@ -1,16 +1,8 @@
-from concurrent.futures import ThreadPoolExecutor
-import datetime
-import os
-import zoneinfo
-import requests
 import time
+from queues import tasks_pb2_grpc
+from queues import tasks_pb2
 
-
-stage = os.getenv("STAGE", 'local')
-if stage == 'local':
-    QUEUES_URL = 'http://localhost:1239'
-else:
-    QUEUES_URL = 'http://queues:1239'
+from google.protobuf import json_format
 
 
 class QueuesException(Exception):
@@ -18,54 +10,23 @@ class QueuesException(Exception):
 
 
 class TasksHandlerMixin:
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-        self.executor = ThreadPoolExecutor(max_workers=1)
-
-    def _send_metric(self, start: datetime.datetime, end: datetime.datetime, success: bool):
-        def send():
-            requests.post(f'{QUEUES_URL}/api/v1/metric', json={
-                'service': 'botalka',
-                'queue': self.queue_name,
-                'success': success,
-                'timestamp': start.strftime("%Y-%m-%dT%H:%M:%S") + "Z",
-                "success": success,
-                "execution_time_ms": (end - start).microseconds // 1000,
-                "environment": stage,
-            })
-        
-        self.executor.submit(send)
-
     def poll(self):
         while True:
-            try:
-                response = requests.get(f'{QUEUES_URL}/api/v1/take', headers={'queue': self.queue_name}).json()
-            except requests.JSONDecodeError:
-                print('Unable to decode json')
-                time.sleep(3)
-                continue
-            task = response.get('task')
+            response: tasks_pb2.TakeResponse = self.stub.Take(tasks_pb2.TakeRequest(queue=self.queue_name))
+            task = response.task
             if not task:
                 time.sleep(0.2)
                 continue
-            start = datetime.datetime.now(zoneinfo.ZoneInfo("Europe/Moscow"))
             try:
-                print(f'process task with id {task["id"]}, attempt {task["attempt"]}')
-                self.process(task['payload'])
-                success = True
+                payload = json_format.MessageToDict(task.payload)
+                self.process(payload)
             except Exception as exc:
-                print(f'Error processing message id={task["id"]}, payload={task["payload"]}, exc={exc}')
-                success = False
-            end = datetime.datetime.now(zoneinfo.ZoneInfo("Europe/Moscow"))
-            if success:
-                try:
-                    resp = requests.post(f'{QUEUES_URL}/api/v1/finish', json={'id': task['id']})
-                    if resp.status_code != 202:
-                        raise QueuesException
-                    print(f'finish task with id {task["id"]}')
-                except:
-                    print(f'Failed to finish task id={task["id"]}')
-            self._send_metric(start, end, success)
+                print(f'Error processing message id={task.id}, payload={payload}, exc={exc}')
+                continue
+            try:
+                self.stub.Finish(tasks_pb2.FinishRequest(id=task.id))
+            except:
+                print(f'Failed to finish task id={task.id}')
 
     @property
     def queue_name(self):
@@ -74,12 +35,12 @@ class TasksHandlerMixin:
     def process(self, payload):
         raise NotImplemented
 
-
-def set_task(queue_name: str, payload: dict, seconds_to_execute: int, delay: int|None = None):
-    resp = requests.post(f'{QUEUES_URL}/api/v1/put', headers={'queue': queue_name}, json={
-        'payload': payload,
-        'seconds_to_execute': seconds_to_execute,
-        'delay': delay,
-    })
-    if resp.status_code != 202:
-        raise QueuesException
+def set_task(stub: tasks_pb2_grpc.TasksStub, queue_name: str, payload: dict, seconds_to_execute: int, delay: int|None = None):
+    stub.Put(
+        tasks_pb2.PutRequest(
+            queue=queue_name, 
+            seconds_to_execute=seconds_to_execute, 
+            delay=delay, 
+            payload=payload
+        )
+    )